Conversation
Contributor
Author
|
@arnodirlam Lets discuss before adding tests. |
ce93eee to
065bf91
Compare
Contributor
|
Thanks a lot for the PR and the work you put in here. I'll have to think about this for a bit and also do some research on other approaches, and will get back to you here 🙏 To get started, why did you choose this approach, and did you consider any other approaches? @ftes |
Contributor
Author
|
Sure, this one's not urgent so definitely worth it to take your time. Tbh I jumped onto the What I considered:
Things it might be worth to consider:
|
065bf91 to
f218395
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Dx.Repo, similar toEcto.RepoDxfunctionsDx.fn(..., opts) > default_options() > Mix.Config > use.